Re: [PATCH 7/14] FRV: GDB stub dependent additional BUG()'s

From: Christoph Hellwig
Date: Wed Nov 03 2004 - 05:41:23 EST


On Tue, Nov 02, 2004 at 04:09:58PM +0000, David Howells wrote:
> What's the best way to add an invoke_debugger() function without having to
> change every arch? #ifdef/#endif in kernel/panic.c maybe...

just put it in every arch. Or even better drop your gdbstub for now
and integrate it with the common kgdb code in -mm.

Actually I think you should do thata anyway.

> Why? If you've got a debugger attached, it'd seem reasonable to want it to
> jump into the debugger in these circumstances; after all, your system is
> probably stuffed after this point.

Because it's not fatal without your debugger, so it shouldn't magically
get fatal. If you think this is fatal convience Andrew to add a BUG() here.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/