Re: [PATCH 2.6.10-rc1] Fix building of samba userland

From: Chris Wedgwood
Date: Wed Nov 03 2004 - 16:07:01 EST


On Wed, Nov 03, 2004 at 12:03:45PM -0700, Tom Rini wrote:

> Hello. After 2.6.8.1, samba userland would no longer build with
> current kernel headers, as it needs some of the samba kernel headers
> to work,

what? the samba userland which i assume is portable and not at all
linux specific needs linux kernel headers?

> +++ edited/include/linux/smb_fs.h 2004-11-03 12:00:07 -07:00
> @@ -12,7 +12,6 @@
> #include <linux/smb.h>
> #include <linux/smb_fs_i.h>
> #include <linux/smb_fs_sb.h>
> -#include <linux/fs.h>
>
> /*
> * ioctl commands
> @@ -26,6 +25,7 @@
>
> #ifdef __KERNEL__
>
> +#include <linux/fs.h>
> #include <linux/pagemap.h>
> #include <linux/vmalloc.h>
> #include <linux/smb_mount.h>

that patch seems harmless enough, but im not sure why it should be
necessary really, i dont see why samba should be including such
headers at all --- it's a bad idea in almost all cases
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/