Re: fix iounmap and a pageattr memleak (x86 and x86-64)

From: Dave Hansen
Date: Thu Nov 04 2004 - 19:42:32 EST


I attached the wrong patch.

Here's what I meant to send.

-- Dave


---

memhotplug1-dave/arch/i386/mm/pageattr.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/i386/mm/pageattr.c~Z0-leaks_only_on_negative arch/i386/mm/pageattr.c
--- memhotplug1/arch/i386/mm/pageattr.c~Z0-leaks_only_on_negative 2004-11-04 15:57:28.000000000 -0800
+++ memhotplug1-dave/arch/i386/mm/pageattr.c 2004-11-04 15:58:50.000000000 -0800
@@ -135,7 +135,7 @@ __change_page_attr(struct page *page, pg
BUG();

/* memleak and potential failed 2M page regeneration */
- BUG_ON(!page_count(kpte_page));
+ BUG_ON(page_count(kpte_page) < 0);

if (cpu_has_pse && (page_count(kpte_page) == 1)) {
list_add(&kpte_page->lru, &df_list);
_