Re: [BK PATCH] Fix ip_conntrack_amanda data corruption bug thatbreaks amanda dumps

[David S. Miller]

On Fri, 5 Nov 2004 02:04:27 +0100
Matthias Andree <matthias.andree@xxxxxx> wrote:

> On Thu, 04 Nov 2004, David S. Miller wrote:
> 
> > His patch isn't correct, even making a temporary change to
> > a shared SKB is illegal.
> 
> So the original ip_conntrack_amanda was already illegal. If only such
> nonsense caused heavy kernel logging (let it oops or GPF or whatver),
> that's a much quicker way to pinpoint the bug than run amanda with a
> special devnull configuration some dozen times.

The original ip_conntrack_amanda was correct before
my skb_header_pointer() changes.  Patrick's patch, which
I'll of course apply, simply reverted those changes back
to the original code which uses the amanda_buffer for
the UDP control stream always.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/