Re: [PATCH] hw_random: Update printk()'s in hw_random.c

[Jim Nelson]

> >  /*
> >   * debugging macros
> >   */
> > -#undef RNG_DEBUG /* define to enable copious debugging info */
> > +#undef DEBUG /* define to enable copious debugging info */
>
>
> I think the '#undef DEBUG' line is supposed to precede all the 
> #includes, yes?

> >  static int rng_dev_open (struct inode *inode, struct file *filp);
> >  static ssize_t rng_dev_read (struct file *filp, char __user *buf, 
> > size_t size,
> > -                 loff_t * offp);
> > +        loff_t * offp);
>
>
> seemingly bogus whitespace change

> > -    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) & 
> > VIA_XSTORE_CNT_MASK;
> > +    bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) &
> > +            VIA_XSTORE_CNT_MASK;
>
>
> bogus whitespace change
> -


All right.  I'll back out the whitespace changes and move the #undef to the top of 
the #includes, and re-submit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/