Re: bloat

[Adrian Bunk]

On Sat, Nov 06, 2004 at 10:41:47PM +0100, Andries Brouwer wrote:
> On Sat, Nov 06, 2004 at 08:36:08PM +0100, Adrian Bunk wrote:
> 
> > It's even harder because some subsystem maintainers refuse to remove 
> > unused global functions that might be used at some point far in the 
> > future or that even are never intended for in-kernel usage...
> 
> I have one or two unused functions inside #if 0 in sddr09.c.
> Finding out the proper hardware details was nontrivial,
> it would be a pity to throw the knowledge away.
> But of course there is never a reason to have an unused function
> appear in the binary. It is only source bloat.

No disagreement on this issue.

But unused global functions that are even EXPORT_SYMBOL'ed like in the 
ACPI and FireWire cases are not only source bloat...

> Andries

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/