Re: 2.6.10-rc1 bttv oops in btcx_riscmem_free

[Peter Osterlund]

Peter Osterlund <petero2@xxxxxxxxx> writes:

> Eyal Lebedinsky <eyal@xxxxxxxxxxxxxx> writes:
> 
> > Watching on Mythtv, I stopped watching on the client. at this point
> > the picture froze. Looking in dmesg I see this oops. The machine
> > quicly becomes unusable ('ps aux' hangs).
> > 
> > I then applied the v4l patches off the list. Still the same problem.
> > 
> > Unable to handle kernel paging request at virtual address 85525fe9
> 
> I have similar problems using 2.6.10-rc1-bk8. Often when I exit
> tvtime, I get "unable to handle kernel paging request" or "unable to
> handle kernel NULL pointer", see below.

I found the bug. Here is a patch to fix it.

Signed-off-by: Peter Osterlund <petero2@xxxxxxxxx>
---

 linux-petero/drivers/media/video/video-buf.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/media/video/video-buf.c~bttv-fix3 drivers/media/video/video-buf.c
--- linux/drivers/media/video/video-buf.c~bttv-fix3	2004-11-07 00:10:04.632421064 +0100
+++ linux-petero/drivers/media/video/video-buf.c	2004-11-07 00:10:04.635420608 +0100
@@ -1063,7 +1063,7 @@ videobuf_vm_close(struct vm_area_struct 
 				continue;
 			map->q->bufs[i]->map   = NULL;
 			map->q->bufs[i]->baddr = 0;
-			map->q->ops->buf_release(vma->vm_file,map->q->bufs[i]);
+			map->q->ops->buf_release(vma->vm_file->private_data,map->q->bufs[i]);
 		}
 		kfree(map);
 	}
_

-- 
Peter Osterlund - petero2@xxxxxxxxx
http://w1.894.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/