Re: [PATCH/RFC 1/4]device core changes
From: Greg KH
Date: Mon Nov 08 2004 - 18:18:17 EST
On Mon, Nov 08, 2004 at 12:11:11PM +0800, Li Shaohua wrote:
> This is the device core change required. Add .platform_bind method for
> bus_type, so platform can do addition things when add a new device. A
> case is ACPI, we want to utilize some ACPI methods for physical devices.
> 1. Why doesn't use 'platform_notify'?
> Current device core has a 'platform_notify' mechanism, but it's not
> sufficient for this. Only sepcific bus type know how to parse dev.bus_id
> and know how to encode specific device's address into ACPI _ADR syntax.
I don't see why platform_notify is not sufficient. This is the exact
reason it was added to the code.
> 2. Why adds new 'handle' in 'struct device'?
> 'Platform_data' is the best candidate, but a search shows some drivers
> have used it. We can remove 'handle' after the drivers changes their
No, fix the drivers. Don't add something that you are going to remove
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/