Re: [PATCH] ibm-acpi-0.8 (was Re: 2.6.10-rc1-mm3)
From: Chris Wright
Date: Mon Nov 08 2004 - 21:13:28 EST
* Borislav Deianov (borislav@xxxxxxxxxxxxxxxxxxxxx) wrote:
> On Mon, Nov 08, 2004 at 03:30:22PM -0800, Chris Wright wrote:
> > The init error cleanup paths are broken in that driver. It creates the
> > /proc/acpi/ibm dir and forgets to clean it up. Partially that's due to
> > returning directly from the macro IBM_HANDLE_INIT_REQ. This should help.
> Yikes. Guilty as charged.
> I reworked Chris's patch a bit and tried both the error and non-error
> case here. Len, if it looks good, please apply.
Ah, even better. Thanks Boris. BTW, you could probably mark ibm_init()
and ibm_handle_init() as __init.
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/