Re: [PATCH] VM routine fixes

From: David Howells
Date: Tue Nov 09 2004 - 08:56:13 EST

> Please don't stick CONFIG_MMU all over the place but keep them in as small
> as possible blocks.

You seem to have changed your mind. Last I heard from you wanted them in as
few large blocks as possible. Now you want them in many small blocks. If you
want it changing, please feel free to supply me with a patch.

> As I told you before please move registration of MMU-only sysctls
> to a MMU-only file in mm/

No. These belong in the vm_table. It doesn't seem especially straightforward
to do what you want. If you want it doing your way, then feel free to send
Andrew a patch.

> > +extern void set_page_refs(struct page *page, int order);
> this should probably be an inline.

Probably. I'll deal with that after Andrew/Linus take my patches, if they take
my patches.

> this is nasty. The right thing would probably to swich !MMU arches
> to use the compount-page mechanism from the hugetlb code for this.

Supply me with a patch and I'll test it. I don't know how the compound-page
stuff works, but it's quite possibly the wrong way to do it. There is no MMU
available, so you can't generate adjacency that way.

> And you ocmpletely ignored the previous comment here aswell.

No, I didn't; you're wrong.

Feel free to supply a patch to change it to what you think is correct. I'll
test it for you.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at