Re: [PATCH] do_wait fix for 2.6.10-rc1
From: Linus Torvalds
Date: Tue Nov 09 2004 - 11:13:42 EST
On Tue, 9 Nov 2004, Dinakar Guniguntala wrote:
> All of your patches address the TASK_STOPPED case, whereas the current
> problem that Sripathi reported does not have a task in the stopped state.
Sorry, I'm a retard.
> Hence the patches Sripathi sent which did fix the problem, but they end up
> busy looping because of schedule. The only clean solution seems to be to
> wake up the siblings if there are any in the case we reap a process from
> wait_task_zombie. What do you think?
Ok, that was my original second suggestion, but the more I think about it,
the more unnecessarily complicated it sounds.
I think I have a potentially better approach: make the rules for "flag" a
bit more explicit, and make it have structure. We use "flag" for two
things: we use it to determine if we should return -ECHILD (no children),
and for whether we should wait for something that might become available
later. So just split up "flag" into these two meanings, instead of just
trying to use a single bit:
- one bit that says "we found a child that _will_ wake us up when it's
ready". In other words, that's a child that is ours, and is not yet a
- one bit that says "we found a child that is ours".
Make "eligible_child()" follow these rules, and then instead of just
setting "flag = 1", we'd set "flag |= ret".
Now, with these rules, we know just what to do: we only do the wait if the
"we have children that will wake us up" bit is set. But we return ECHILD
only if flag is totally clear.
Does that sound like it would fix the problem?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/