Re: [PATCH 1/4] Move check for invalid chars tovfat_valid_longname()

From: OGAWA Hirofumi
Date: Tue Nov 09 2004 - 13:45:33 EST


Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx> writes:

> But doesn't imply this we can't do any of our checks on the VFS
> string?

Basically yes.

> A dot (0x2E) at the end of a filename could be the half of some other
> character in some encoding, right?

'.'/' ' is not contained as second byte by any encodings, at least
current nls is supporting encodings.

> And the same could be said about the checks in
> vfat_valid_longname(), no?

These are string, not char. These should be unique.

> The patch you asked for converting IS_BADCHAR to an inline function
> follows. I rolled it together with the other conversions from patch 3.
> Applies directly on top of 2.6.10-rc1-bk18.

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/