Re: Synchronization primitives in UML (was: Re: [uml-devel] Re: [patch 09/20] uml: use SIG_IGN for empty sighandler)
Date: Tue Nov 09 2004 - 14:15:57 EST
On Tuesday 09 November 2004 21:48, Jeff Dike wrote:
> blaisorblade_spam@xxxxxxxx said:
> > I also understand now what all this is for. When I have time for this,
> > I'll at least copy and paste your mail into a comment, with any
> > needed adjustment.
> That would be a good idea.
> > For the semaphore issue, I have some ideas (like using futexes) which
> > need to be developed a bit:
> > 1) I want to create a semaphore API in os_*.
> > 2) It will be able to use socketpairs.
> > 3) It will be able to use futexes, if they are
> > non-persistant and usable without too much issues (the same way we
> > are going to support Async I/O).
> > 4) It will be used first by the code
> > which could really benefit from the performance increase.
> > 5) It won't
> > use persistant objects.
> This all sounds good, although there are simplicity benefits to just using
> one underlying mechanism, as long as there are no overriding disadvantages
> to it.
Yes, I would like that, too, but futexes are 2.6 only, and probably also
NPTL-only (we are going to fix that, at least for SKAS mode), but faster than
anything else. Nothing apart this.
> > Any comment on these issues? Also, apart TT context switching, is
> > there any other performance-sensitive use of semaphores, which would
> > benefit from using futexes?
> Offhand, I think context switching is the most sensitive one.
Ok. But to get TT mode to work against NPTL glibc, which is required for
futexes, we need to recode the "thread_private" section in uml.lds.S to work
with NPTL glibc. It seems that binutils does not like that (the error is "not
enough program header allocated", which refers to the fact that
SIZEOF_HEADERS is guessed and then used. Not using SIZEOF_HEADERS could help,
if doing this is possible).
> > Yes, semget and friends are uglier.
> > But don't think that the current nested code is simple to read - three
> > semaphores at a time, without a clear name, are not the clearer code
> > on the world.
> What nested code are you talking about?
There are two down() and two up(); additionally, run_helper_thread() manages
at least another pipe(). I don't see an easy way to simplifying all this, but
it's needed (or at least some comment should be added). Just a cleanup,
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/