Re: 2.6.10-rc1-mm4

From: Jens Axboe
Date: Tue Nov 09 2004 - 16:18:56 EST

On Tue, Nov 09 2004, Andrew Morton wrote:
> Jens Axboe <axboe@xxxxxxx> wrote:
> >
> > On Tue, Nov 09 2004, Andrew Morton wrote:
> > > +blk_sync_queue-updates.patch
> > >
> > > update an update to the md updates
> >
> > I still don't think this is a good general export, it has very
> > specialized use. For example, from the description it looks like this
> > can be generally used on any block device and when it returns, we have
> > synced the queue. This simply isn't true, there are absolutely no
> > guarentees of that nature unless the block driver itself implements the
> > __make_request() functionality and has taken proper precautions to
> > prevent this already.
> True. So what do we do? Grit our teeth and move it into MD?

That, or just comment it appropriately instead. Or, perhaps better, make
a real interface that works for both types of devices. It's even
confusing that the final queue cleanup and md can use the same
blk_sync_queue function, it's more by 'chance' than by design because
the driver queue is already in a known and shut down state. So I don't
like it at all.

The blk_freeze_queue() stuff I suggested should work, I'll try and make
a patch.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at