[PATCH 25/26] NTFS 2.1.22 - Bug and race fixes and improved error handling.

From: Anton Altaparmakov
Date: Wed Nov 10 2004 - 09:13:03 EST

This is patch 25/26 in the series. It contains the following ChangeSet:

<aia21@xxxxxxxxxx> (04/11/09 1.2026.1.65)
NTFS: Disable the file size changing code from
fs/ntfs/aops.c::ntfs_prepare_write() for now as it is not safe.

Signed-off-by: Anton Altaparmakov <aia21@xxxxxxxxxx>

Best regards,

Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/, http://www-stu.christs.cam.ac.uk/~aia21/


diff -Nru a/fs/ntfs/ChangeLog b/fs/ntfs/ChangeLog
--- a/fs/ntfs/ChangeLog 2004-11-10 13:45:52 +00:00
+++ b/fs/ntfs/ChangeLog 2004-11-10 13:45:52 +00:00
@@ -49,11 +49,6 @@
- In fs/ntfs/aops.c::ntfs_writepage(), if the page is fully outside
i_size, i.e. race with truncate, invalidate the buffers on the page
so that they become freeable and hence the page does not leak.
- - Implement extension of resident files in the regular file write code
- paths (fs/ntfs/aops.c::ntfs_{prepare,commit}_write()). At present
- this only works until the data attribute becomes too big for the mft
- record after which we abort the write returning -EOPNOTSUPP from
- ntfs_prepare_write().
- Remove unused function fs/ntfs/runlist.c::ntfs_rl_merge(). (Adrian
- Fix stupid bug in fs/ntfs/attrib.c::ntfs_attr_find() that resulted in
diff -Nru a/fs/ntfs/aops.c b/fs/ntfs/aops.c
--- a/fs/ntfs/aops.c 2004-11-10 13:45:52 +00:00
+++ b/fs/ntfs/aops.c 2004-11-10 13:45:52 +00:00
@@ -1884,6 +1884,12 @@
/* If we do not need to resize the attribute allocation we are done. */
if (new_size <= vi->i_size)
goto done;
+ // FIXME: We abort for now as this code is not safe.
+ ntfs_error(vi->i_sb, "Changing the file size is not supported yet. "
+ "Sorry.");
+ return -EOPNOTSUPP;
/* Map, pin, and lock the (base) mft record. */
if (!NInoAttr(ni))
base_ni = ni;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/