Re: [PATCH] fix platform_rename_gsi related ia32 build breakage

From: Linus Torvalds
Date: Wed Nov 10 2004 - 19:31:52 EST

On Wed, 10 Nov 2004, Arnaldo Carvalho de Melo wrote:
> This one compiles and links OK.

Including when CONFIG_ACPI_BOOT is set? Does it see the prototype then?
Looks like <asm/acpi.h> should be included, but I assume it gets included
some other way?

Quite frankly, I think the whole thing is broken. #ifdef's inside code is
_evil_, and "platform_rename_gsi()" doesn't make sense as a name. I'll
apply your patch, but quite frankly, I think the ACPI layer is doing crap.

Len, can you please use a more descriptive name, and have it be always
defined (make it an inline function that just becomes a no-op or

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at