Re: Broken kunmap calls in rc4-mm1.

From: Andrew Morton
Date: Thu Nov 11 2004 - 02:51:47 EST


Jens Axboe <axboe@xxxxxxx> wrote:
>
> On Wed, Nov 10 2004, Andrew Morton wrote:
> > Nigel Cunningham <ncunningham@xxxxxxxxxxxxx> wrote:
> > >
> > > Remaining culprits are....
> > >
> > > Reiser4:
> > > - do_readpage_tail
> > > -reiser4_status_init
> > > -reiser4_status_write
> >
> > obuggerit. Look, a simple helper is to redefine kmap_atomic() and
> > kunmap_atomic() to work on char*'s. This will spit warnings if someone
> > feeds in a page*. Which would be a lot more useful if we didn't have all
> > those infernal __iomem warnings scrolling off the screen but ho hum.
>
> I tried something like this, but got stuck on people passing a structure
> in which is valid (aio_setup_ring(), for instance). We can always cast
> those of course, but it's not so pretty.

yup, that's what I did. It's not too bad, apart from cachefs which has
gone kmap nutso.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/