Re: [PATCH] UML - signal bug fix

From: Bodo Stroesser
Date: Thu Nov 11 2004 - 13:23:55 EST


Jeff Dike wrote:
This patch fixes a bug introduced in the last batch of signal fixes. The
system call return value should only be reset if called diectly from a system
call, i.e. sigsuspend. The fixes added earlier caused any interrupted non-zero
system call return to be reset, confusing fork and vfork, among others.

Signed-off-by: Jeff Dike <jdike@xxxxxxxxxxx>

Yes. The patchset was wrong.
But IMHO the solution shouldn't be resetting to the old state, that did syscall
restarting wrong!
The problem, you fix here, doesn't occur, when using my complete patchset. And my
patches fix UML's wrong syscall restart handling. And other issues they fix, too.

Bodo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/