Re: Recent I2C "dead code removal" breaks pmac sound.
From: Greg KH
Date: Thu Nov 11 2004 - 13:28:50 EST
On Thu, Nov 11, 2004 at 07:09:02PM +0100, Gabriel Paubert wrote:
> a recent patch to drivers/i2c/i2c-core.c removed a bunch of
> functions because they were unused; i2c_smbus_write_block_data
> was in the lot. I happen to have a different definition of dead
> code since grepping for it reveals (in sound/ppc/pmac.h):
> #define snd_pmac_keywest_write(i2c,cmd,len,data) i2c_smbus_write_block_data((i2c)->client, cmd, len, data)
> I only get a link time error since the removed functions are still
> declared in include/linux/i2c.h, and that is certainly wrong.
> For now I have successfully compiled with the following patch
> which ressuscitates the function I need. In a recent pull, the
> offending cset is 1.2114.2.8 from November 5th by arjan.
> This patch is _not_ final, but I don't know what sould be done:
> excluding the cset, or applying the following and making
> the include file match the existing functions, or something
> completely different?
Put the function back, and change the pmac.h file to delete the #define,
and replace the snd_pmac_keywest_write function with a real call to
i2c_smbus_write_block_data so things like this don't happen again.
Care to write a patch to do this?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/