Re: Recent I2C "dead code removal" breaks pmac sound.

From: Greg KH
Date: Fri Nov 12 2004 - 16:32:31 EST

On Fri, Nov 12, 2004 at 01:22:15PM +0100, Gabriel Paubert wrote:
> > Put the function back, and change the pmac.h file to delete the #define,
> > and replace the snd_pmac_keywest_write function with a real call to
> > i2c_smbus_write_block_data so things like this don't happen again.
> >
> > Care to write a patch to do this?
> It follows, along with an update of the include/linux/i2c.h to only
> declare functions that actually exist, but grepping the whole sound
> subtree shows that at least sound/oss/dmasound/tas_common.h defines
> a few inline functions that call i2c_smbus_write_{byte,block}_data.
> It might be reasonable to split it into two ChangeSets, that's
> your call.
> Compiled, booted, tested and CC'ed to BenH just in case.

Applied, thanks.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at