[PATCH] include ordering breaks sysrq on 8250 serial

From: Matt Mackall
Date: Fri Nov 12 2004 - 17:30:19 EST

This has been pestering me for a couple days, finally dug into it:

serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was
getting set up. I suspect this problem exists elsewhere. Tested
against latest bk snapshot.

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

Index: l-bk20/drivers/serial/8250.c
--- l-bk20.orig/drivers/serial/8250.c Fri Nov 12 13:03:25 2004
+++ l-bk20/drivers/serial/8250.c Fri Nov 12 14:19:04 2004
@@ -20,6 +20,11 @@
* membase is an 'ioremapped' cookie.
#include <linux/config.h>
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/tty.h>
@@ -37,10 +42,6 @@
#include <asm/io.h>
#include <asm/irq.h>

-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
#include <linux/serial_core.h>
#include "8250.h"

Mathematics is the supreme nostalgia of our time.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/