Re: [PATCH] More Driver Core patches for 2.6.10-rc1

From: Greg KH
Date: Fri Nov 12 2004 - 19:50:42 EST


Replied to both of you, and the list, to prevent others from pointing
out the same thing multiple times :)

Oh, it's nice to see that people actually read these patches, I like it.


On Sat, Nov 13, 2004 at 12:20:17AM +0100, Kenneth Aafl?y wrote:
> On Saturday 13 November 2004 00:00, Greg KH wrote:
> > ChangeSet 1.2094, 2004/11/12 11:42:03-08:00, miltonm@xxxxxxx
> >
> > [PATCH] fix sysfs backing store error path confusion
> [snip]
> > sd = sysfs_new_dirent(parent_sd, element);
> > if (!sd)
> > - return 0;
> > + return -ENOMEMurn -ENOMEM;
>
> Confusingly strange :)
>
> Kenneth

On Sat, Nov 13, 2004 at 01:00:52AM +0100, Francois Romieu wrote:
> Greg KH <greg@xxxxxxxxx> :
> [...]
> > diff -Nru a/fs/sysfs/dir.c b/fs/sysfs/dir.c
> > --- a/fs/sysfs/dir.c 2004-11-12 14:53:33 -08:00
> > +++ b/fs/sysfs/dir.c 2004-11-12 14:53:33 -08:00
> [...]
> > @@ -56,7 +56,7 @@
> >
> > sd = sysfs_new_dirent(parent_sd, element);
> > if (!sd)
> > - return 0;
> > + return -ENOMEMurn -ENOMEM;
>
> Oops.

Yeah, I don't know what happened with my tools here. But if you look at
the next patch in the series, I fixed it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/