Re: [BK PATCH] More Driver Core patches for 2.6.10-rc1

From: Greg KH
Date: Sat Nov 13 2004 - 16:18:16 EST


On Sat, Nov 13, 2004 at 12:51:41PM -0800, Linus Torvalds wrote:
>
>
> On Fri, 12 Nov 2004, Greg KH wrote:
> >
> > David Brownell:
> > o driver core: shrink struct device a bit
> >
> > Greg Kroah-Hartman:
> > o driver core: fix up some missed power_state changes from David's patch
>
> Hmm. Apparently drivers/ide/ppc/pmac.c wasn't among those fixed up:
>
> drivers/ide/ppc/pmac.c: In function `pmac_ide_macio_suspend':
> drivers/ide/ppc/pmac.c:1363: error: structure has no member named `power_state'
> drivers/ide/ppc/pmac.c:1366: error: structure has no member named `power_state'
> ...

Oops, sorry about that.

> Is it always valid to just replace
>
> dev->dev.power_state
>
> with
>
> dev->dev.power.power_state

Yes it is.

> or is there anything subtler going on?

Nope, nothing subtle here :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/