Re: Futex queue_me/get_user ordering (was: 2.6.10-rc1-mm5 [u])

From: Andrew Morton
Date: Sun Nov 14 2004 - 04:11:44 EST

Emergency Services Jamie Lokier <jamie@xxxxxxxxxxxxx> wrote:
> Revert the patch which moves queue_me(); it's buggy. It is a bug to
> move queue_me() after get_user().


> It fully explains the blocking threads in Apache and Evolution.
> Even if it worked, the patch wouldn't have saved any time, as it's a
> rare condition if the caller is using futex properly.

The patch wasn't supposed to optimise anything. It fixed a bug which was
causing hangs. See

Or are you saying that userspace is buggy??
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at