Re: [PATCH] PNP support for i8042 driver

From: matthieu castet
Date: Sun Nov 14 2004 - 07:23:23 EST

Dmitry Torokhov wrote:
On Saturday 13 November 2004 08:23 am, matthieu castet wrote:

this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi is try before the pnp driver so if you don't disable ACPI or apply others pnpacpi patches, it won't change anything.

Please review it and apply if possible


Matthieu CASTET

Signed-Off-By: Matthieu Castet <castet.matthieu@xxxxxxx>


Do we really need to keep those drivers loaded - i8042 will not
be hotplugged and ports are reserved anyway. We are only interested
in presence of the keyboard and mouse ports. Can we unregister
the drivers (both ACPI and PNP) right after registering and mark
all that stuff as __init/__initdata as in the patch below?
It is better to keep pnp driver loaded because when it unload, the resources will be disabled, so for the motherboards that allow it the irq won't work anymore, and so the keyboard and mouse won't work...
Also it avoid the user to do
"echo disable > /sys/bus/pnp/xx\:xx/resources". Actually, it disables the resources for the mouse even if the driver is using the resource...

I also adjusted init logic so ACPI/PNP can be enabled/disabled
independently of each other.

No problem as long as :
-if there is no acpi support, pnp can be used
-if acpi driver detect nothing, and there is pnp support, pnp driver will be tried before returning an error (it is important because, in the future pnpacpi will "lock" the acpi device, so the acpi driver will find nothing even if there are devices)


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at