[2.6 patch] SCSI NCR53C9x.c: some cleanups

From: Adrian Bunk
Date: Sun Nov 14 2004 - 21:36:44 EST


The patch below contains some cleanups.

Please review the fact that the function esp_command currently has zero
users.


diffstat output:
drivers/scsi/NCR53C9x.c | 15 ++-------------
drivers/scsi/NCR53C9x.h | 1 -
2 files changed, 2 insertions(+), 14 deletions(-)


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.h.old 2004-11-13 16:27:49.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.h 2004-11-13 16:27:41.000000000 +0100
@@ -660,7 +660,6 @@
extern irqreturn_t esp_intr(int, void *, struct pt_regs *);
extern const char *esp_info(struct Scsi_Host *);
extern int esp_queue(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
-extern int esp_command(Scsi_Cmnd *);
extern int esp_abort(Scsi_Cmnd *);
extern int esp_reset(Scsi_Cmnd *);
extern int esp_proc_info(struct Scsi_Host *shost, char *buffer, char **start, off_t offset, int length,
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.c.old 2004-11-13 16:24:51.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.c 2004-11-13 16:28:23.000000000 +0100
@@ -100,7 +100,7 @@
irqreturn_t esp_intr(int irq, void *dev_id, struct pt_regs *pregs);

/* Debugging routines */
-struct esp_cmdstrings {
+static struct esp_cmdstrings {
unchar cmdchar;
char *text;
} esp_cmd_strings[] = {
@@ -505,7 +505,7 @@
}

/* This places the ESP into a known state at boot time. */
-void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
+static void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
{
volatile unchar trash;

@@ -1271,17 +1271,6 @@
return 0;
}

-/* Only queuing supported in this ESP driver. */
-int esp_command(Scsi_Cmnd *SCpnt)
-{
-#ifdef DEBUG_ESP
- struct NCR_ESP *esp = (struct NCR_ESP *) SCpnt->device->host->hostdata;
-#endif
-
- ESPLOG(("esp%d: esp_command() called...\n", esp->esp_id));
- return -1;
-}
-
/* Dump driver state. */
static void esp_dump_cmd(Scsi_Cmnd *SCptr)
{

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/