Re: [2.6 patch] SCSI: misc possible cleanups

From: Adrian Bunk
Date: Mon Nov 15 2004 - 00:13:15 EST

On Sun, Nov 14, 2004 at 10:50:46PM -0600, James Bottomley wrote:
> On Sun, 2004-11-14 at 20:04, Adrian Bunk wrote:
> > This patch below does:
> > - remove unused code
> Erm, some of the code you're trying to remove was recently added as
> enablers for fibre channel drivers, like this:
> [...]
> > drivers/scsi/scsi_transport_fc.c | 202 ------------------------------
> It's really not safe to remove code without understanding why it's there
> in the first place.

That's exactly why I wrote:

<-- snip -->

It is meant for review and not for being applied immediately.
It should simply demonstrate with users are possible with the current
in-kernel users today.

<-- snip -->

OK, the last wasn't a correct sentence.

I wanted to say:
It should simply demonstrate with changes are possible with the current
in-kernel users.

> James



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at