Re: [PATCH]eepro100 resume failure

From: Arjan van de Ven
Date: Mon Nov 15 2004 - 03:45:16 EST




>
> @@ -2337,7 +2337,12 @@ static int eepro100_resume(struct pci_de
> struct speedo_private *sp = netdev_priv(dev);
> long ioaddr = dev->base_addr;
>
> + pci_set_power_state(pdev, 0);
> pci_restore_state(pdev);
> + if (pdev->is_enabled)
> + pci_enable_device(pdev);
> + if (pdev->is_busmaster)
> + pci_set_master(pdev);

this is wrong; the driver should KNOW the device is enabled; no reason
to check for is_enabled. Same for is_busmaster...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/