Re: [PATCH]eepro100 resume failure

From: Li Shaohua
Date: Mon Nov 15 2004 - 04:04:28 EST


On Mon, 2004-11-15 at 16:58, Arjan van de Ven wrote:
> > + pci_set_power_state(pdev, 0);
> > pci_restore_state(pdev);
> > + pci_enable_device(pdev);
> > + pci_set_master(pdev);
> >
>
> one more nitpick; pci_enable_device() already calls
> pci_set_power_state()... isn't that double up now ?
>
I think 'pci_restore_state' should be called after
'pci_set_power_state'.

Thanks,
Shaohua

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/