Re: [PATCH] VM routine fixes

From: David Howells
Date: Mon Nov 15 2004 - 08:18:23 EST



> > vm_area_struct not having an ops member? There's no real need for ops on
> > uClinux since almost all of the ops are irrelevant.
>
> I don't think that is a valid argument.
>
> If uClinux wants to be a different source-base, then go wild. But if you
> want to integrate into the standard kernel, there are other priorities.
> One of them is that it has to integrate cleanly. And that means that we
> don't do micro-optimizations that make the non-MMU case affect mainline
> code unless there is a damn good reason.

So not having an MMU, page tables or PTEs or any requirement for operations
that act upon them is not enough?

Do you then want me to use the MMU version of struct vm_area_struct for both
MMU and !MMU? It can be done, almost. I'll need to add one member variable (a
refcount).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/