Re: [2.6 patch] MTD: some cleanups

From: David Woodhouse
Date: Tue Nov 16 2004 - 13:33:12 EST


On Fri, 2004-11-12 at 14:53 +0100, Adrian Bunk wrote:
> The patch below makes the following cleanups for code under drivers/mtd/ :
> - make some needlessly global code static

OK.

> - remove the following unused code:
> - function ftl_freepart in drivers/mtd/ftl.c

It's a bug that we never free these. We should call the function
occasionally instead of deleting it.

> - functions nettel_eraseconfig and nettel_erasecallback,
> struct nettel_erase in drivers/mtd/maps/nettel.c

The nettel_eraseconfig() function isn't static -- I assume it was called
from the nettel-specific platform code.

> - function physmap_set_partitions in drivers/mtd/maps/physmap.c

Again that's called from elsewhere.

--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/