Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup.

[James Morris]

On Wed, 17 Nov 2004, Jesper Juhl wrote:

> Not exactely : 
> 
> 
> > -		if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) {
> 
> > +	err = move_addr_to_kernel(umyaddr, addrlen, address);
> > +	if (err)
> > +		goto out_put;
> 
> 
> The original tests for err >= 0, your replacement tests if err is != 0

Look at move_addr_to_kernel(), it only returns 0 or -error.

The patch looks good to me.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/