Re: RFC: [2.6 patch] i386: always enable REGPARM

From: Linus Torvalds
Date: Wed Nov 17 2004 - 11:09:51 EST




On Wed, 17 Nov 2004, Adrian Bunk wrote:
>
> Is there still a known reason to disable CONFIG_REGPARM on i386 with
> gcc 3?

I wouldn't want to remove the config option, but we _can_ turn it around,
and just force it to 'y'. And if nobody reports any strange problems in
a few months, _then_ we can remove it.

I just make the diff be something like the appended.

Linus

----
===== arch/i386/Kconfig 1.134 vs edited =====
--- 1.134/arch/i386/Kconfig 2004-10-21 18:35:11 -07:00
+++ edited/arch/i386/Kconfig 2004-11-17 08:07:06 -08:00
@@ -862,17 +862,8 @@
default y

config REGPARM
- bool "Use register arguments (EXPERIMENTAL)"
- depends on EXPERIMENTAL
- default n
- help
- Compile the kernel with -mregparm=3. This uses an different ABI
- and passes the first three arguments of a function call in registers.
- This will probably break binary only modules.
-
- This feature is only enabled for gcc-3.0 and later - earlier compilers
- generate incorrect output with certain kernel constructs when
- -mregparm=3 is used.
+ bool
+ default y

endmenu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/