Re: [PATCH] trivial, uninline do_trap(), remove get_cr2()

[Randy.Dunlap]

Oleg Nesterov wrote:
> Uninlining do_trap() saves 544 bytes in traps.o.
> get_cr2() seems to be unused, remove it.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>
> --- 2.6.10-rc2/arch/i386/kernel/traps.c~	Tue Nov 16 14:13:08 2004
> +++ 2.6.10-rc2/arch/i386/kernel/traps.c	Wed Nov 17 16:47:41 2004
> @@ -358,16 +358,7 @@ static inline void die_if_kernel(const c
>  		die(str, regs, err);
>  }
>  
> -static inline unsigned long get_cr2(void)
> -{
> -	unsigned long address;
> -
> -	/* get the address */
> -	__asm__("movl %%cr2,%0":"=r" (address));
> -	return address;
> -}

Looks like it can be removed from arch/x86_64/kernel/traps.c also.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/