Re: [2.6.10-rc2-mm1] OOPS on boot (hotplug related?)

From: Mathieu Segaud
Date: Wed Nov 17 2004 - 20:17:54 EST


Andrew Morton <akpm@xxxxxxxx> disait dernièrement que :

> Christian Axelsson <smiler@xxxxxxxxxxxxx> wrote:
>>
>> I'm getting OOPSes on boot on my laptop. Output is copied by hand and Ive
>> only included the parts that I *think* are useful:
>>
>> ...
>> EIP is at get_nonexclusive_access+0x13/0x40
>
> Yup, seems that reiser4 broke. I've forwarded a copy of an earlier report
> to reiserfs-dev@xxxxxxxxxxxx

V. Saveliev provided the right fix shortly after I reported this oops.

I attach the patch

Regards,

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/11/15 16:23:47+03:00 vs@xxxxxxxxxxxxxxxxxxxxx
# unix_file_filemap_nopage: missing context creation is added
#
# plugin/file/file.c
# 2004/11/15 16:23:45+03:00 vs@xxxxxxxxxxxxxxxxxxxxx +5 -1
# unix_file_filemap_nopage: missing context creation is added
#
diff -Nru a/plugin/file/file.c b/plugin/file/file.c
--- a/plugin/file/file.c 2004-11-17 09:36:11 +03:00
+++ b/plugin/file/file.c 2004-11-17 09:36:11 +03:00
@@ -1961,8 +1961,10 @@
{
struct page *page;
struct inode *inode;
-
+ reiser4_context ctx;
+
inode = area->vm_file->f_dentry->d_inode;
+ init_context(&ctx, inode->i_sb);

/* block filemap_nopage if copy on capture is processing with a node of this file */
down_read(&reiser4_inode_data(inode)->coc_sem);
@@ -1972,6 +1974,8 @@

drop_nonexclusive_access(unix_file_inode_data(inode));
up_read(&reiser4_inode_data(inode)->coc_sem);
+
+ reiser4_exit_context(&ctx);
return page;
}



--
Lisa R. Nelson wrote:
> So much for a friendly group.

You really have seen nothing yet :-)

- Bas Mevissen on linux-kernel