Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg whenusing SELinux and SOCK_SEQPACKET

From: James Morris
Date: Wed Nov 17 2004 - 23:26:58 EST

On Wed, 17 Nov 2004, James Morris wrote:

> There is a non SELinux-related bug lurking in this code.

I also got this when trying to kill the server (which seems to run at 100%
during exit after receving a message sent with sendto() + address):

Badness in sk_del_node_init at include/net/sock.h:343
[<c010339a>] dump_stack+0x17/0x19
[<c03193bc>] __unix_remove_socket+0x64/0x66
[<c03196e4>] unix_release_sock+0x2b/0x259
[<c02bdf07>] sock_release+0x7a/0xda
[<c02be973>] sock_close+0x21/0x3d
[<c0151b2c>] __fput+0x11d/0x15b
[<c015052a>] filp_close+0x42/0x74
[<c0102525>] sysenter_past_esp+0x52/0x71

Which is:

static __inline__ int sk_del_node_init(struct sock *sk)
int rc = __sk_del_node_init(sk);

if (rc) {
/* paranoid for a while -acme */
WARN_ON(atomic_read(&sk->sk_refcnt) == 1); <-- here

- James
James Morris

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at