Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg whenusing SELinux and SOCK_SEQPACKET

[James Morris]

On Thu, 18 Nov 2004, Alan Cox wrote:

> On Iau, 2004-11-18 at 08:27, James Morris wrote:
> > 2) Ensure that unix_dgram_sendmsg() fails for SOCK_SEQPACKET sockets which
> > are not connected, otherwise someone could bypass LSM by sending on an
> > unconnected socket.
> 
> What about half closed and other connected states ? This patch seems
> inadequate for things like X.25

The patch only affects the Unix code and does not change existing 
semantics for other connected states.

One thing that looks broken (unrelated to the patch I posted) is that
unix_dgram_sendmsg() already does not check sk->sk_shutdown &
SEND_SHUTDOWN for SOCK_SEQPACKET.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/