Re: [KJ] [PATCH] floppy: Reorganize drivers/block/floppy.c

[Jim Nelson]

maximilian attems wrote:
> On Thu, 04 Nov 2004, james4765@xxxxxxxxxxx wrote:
>
>
> > Organization of global variables, macros, and #defines in floppy.c
> >
> > Signed-off-by: James Nelson <james4765@xxxxxxxxx>
> >
> > diff -urN --exclude='*~' linux-2.6.9-original/drivers/block/floppy.c linux-2.6.9/drivers/block/floppy.c
> > --- linux-2.6.9-original/drivers/block/floppy.c	2004-10-18 17:53:22.000000000 -0400
> > +++ linux-2.6.9/drivers/block/floppy.c	2004-11-04 20:25:28.180478012 -0500
>
>
> hmm could you split up your patch in logical hunks?

Well, it won't apply to 2.6.10-rc2 anyway (sone ACPI stuff was added), so it 
wouldn't be any less work to re-do it ;)

I guess I'll just take it in smaller chunks, then - spread out over a few -rc's.

> nitpicking: your patch adds whitespace.
>
> a++ maks
> -

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/