Re: 2.6.10-rc2 doesn't boot (if no floppy device)

From: Adrian Bunk
Date: Sun Nov 21 2004 - 11:41:57 EST


On Sat, Nov 20, 2004 at 10:28:27AM -0800, Linus Torvalds wrote:
>...
> So I think the simpler fix is just this one-liner: we should not disable
> preexisting links, because non-PCI devices may depend on the same routing
> information, and thus the comments about "being activated on use" is not
> actually true.

I can confirm this patch fixes the problem for me in an otherwise
unmodified 2.6.10-rc2.

> Linus
>
> ===== drivers/acpi/pci_link.c 1.34 vs edited =====
> --- 1.34/drivers/acpi/pci_link.c 2004-11-01 23:40:09 -08:00
> +++ edited/drivers/acpi/pci_link.c 2004-11-20 09:43:56 -08:00
> @@ -685,9 +685,6 @@
> acpi_link.count++;
>
> end:
> - /* disable all links -- to be activated on use */
> - acpi_ut_evaluate_object(link->handle, "_DIS", 0, NULL);
> -
> if (result)
> kfree(link);

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/