Re: [PATCH]: 2/4 mm/swap.c cleanup

[Hugh Dickins]

On Mon, 22 Nov 2004, Nikita Danilov wrote:
> Andrew Morton writes:
>  > 
>  > Sorry, this looks more like a dirtyup to me ;)
> 
> Don't tell me you are not great fan on comma operator abuse. :)
> 
> Anyway, idea is that by hiding complexity it loop macro, we get rid of a
> maze of pvec-loops in swap.c all alike.
> 
> Attached is next, more typeful variant. Compilebootentested.

You're scaring me, Nikita.  Those loops in mm/swap.c are easy to follow,
whyever do you want to obfuscate them with your own macro maze?

Ingenious for_each macros make sense where it's an idiom which is going
to be useful to many across the tree; but these are just a few instances
in a single source file.

Please find a better outlet for your talents!

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/