Re: [PATCH]: 3/4 mm/rmap.c cleanup

[Hugh Dickins]

On Sun, 21 Nov 2004, Andrew Morton wrote:
> Nikita Danilov <nikita@xxxxxxxxxxxxx> wrote:
> >
> > mm/rmap.c:page_referenced_one() and mm/rmap.c:try_to_unmap_one() contain
> >  identical code that
> > 
> >   - takes mm->page_table_lock;
> > 
> >   - drills through page tables;
> > 
> >   - checks that correct pte is reached.
> > 
> >  Coalesce this into page_check_address()
> 
> Looks sane, but it comes at a bad time.  Please rework and resubmit after
> the 4-level pagetable code is merged into Linus's tree, post-2.6.10.

Personally, I prefer the straightforward way it looks without Nikita's
patch.  But it is a matter of personal taste, and I may well be in the
minority.

Would be better justified if the common function were not "inline"?

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/