Re: [2.6 patch] small drivers/atm cleanups (fwd)

From: Andrew Morton
Date: Tue Nov 23 2004 - 21:15:37 EST


Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> /*
> - * This routine will clock the Read_Status_reg function into the X2520
> - * eeprom, then pull the result from bit 16 of the NicSTaR's General Purpose
> - * register.
> - */
> -
> -u_int32_t
> -nicstar_read_eprom_status( virt_addr_t base )

I'd be inclined to whack an #if 0 around functions such as this rather than
removing them. Someone may come along one day and do some work on the
driver, and nicstar_read_eprom_status() may prove to be useful to them.

Nobody would ever thing to go trolling back through the revision history
looking to see if previously-interesting stuff was deleted.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/