Re: [linux-usb-devel] [PATCH] Ohci-hcd: fix endless loop (second take)

[David Brownell]

On Friday 26 November 2004 02:30, Colin Leroy wrote:
> @@ -375,6 +375,11 @@
>  		spin_unlock_irqrestore (&ohci->lock, flags);
>  		set_current_state (TASK_UNINTERRUPTIBLE);
>  		schedule_timeout (1);
> +		if (limit < 1000) {
> +			ohci_warn (ohci, "Can't recover, restarting.\n");
> +			ohci_restart(ohci);
> +			return;
> +		}

So instead of waiting a moment for the ED to finish
its normal processing and move from state ED_UNLINK
into ED_IDLE, you want to always clobber the whole
USB device tree attached to that bus?  That'd happen
quite routinely.

This isn't a good patch either... maybe your best
bet would be to find out why the IRQs stopped getting
delivered.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/