Re: [Alsa-devel] [2.6 patch] ALSA ISA drivers: misc cleanups

From: Takashi Iwai
Date: Fri Nov 26 2004 - 21:11:45 EST


At Thu, 25 Nov 2004 00:27:58 +0100,
Adrian Bunk wrote:
>
> The patch below makes cleanups under sound/isa/ including:
> - make needlessly global code static
> - ad1816a/ad1816a_lib.c: much code was unused starting with the
> global function snd_ad1816a_timer

I prefer disabling this to removal (in case somone wants to add the
timer function).

> - removed EXPORT_SYMBOL's:
> - cs423x/cs4231_lib.c: snd_cs4231_outm
> - es1688/es1688_lib.c: snd_es1688_mixer_read
>
> Please review this patch.

Otherwise looks fine.

Applied it to ALSA tree. Thanks!


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/