Re: [4/7] Xen VMM patch set : /dev/mem io_remap_page_range for CONFIG_XEN

From: Randy.Dunlap
Date: Sat Nov 27 2004 - 11:56:47 EST


Ian Pratt wrote:
@@ -42,7 +42,12 @@ extern void tapechar_init(void);
*/
static inline int uncached_access(struct file *file, unsigned long addr)

Any chance you could just move uncached_access() to some asm/ header for
all arches instead of making the ifdef mess even worse?

I suppose a generic definition could go in asm-generic/iomap.h
with per-architecture definitions in asm/io.h. However, I think
it would make sense to wait until PAT support gets added and then
think through exactly what needs doing rather than reorganising
things now.


What do people think about this? Should I stick with the current
patch that adds another #ifdef to uncached_access, or should I
try pulling it out into asm-generic/iomap.h with per-arch
definitions in asm/io.h ?

Is there anyone working on PAT support? It would be good to have
their input.

Someone from NVidia has posted some PAT patches a few times.
(Terence Ripperda) There's a thread beginning here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=108180930118848&w=2

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/