Re: [PATCH] CKRM: 3/10 CKRM: Core ckrm, rcfs

[Randy.Dunlap]

Greg KH wrote:
> On Mon, Nov 29, 2004 at 02:28:32PM -0800, Roland Dreier wrote:
>
> >    Greg> Ick.  Don't put a _t at the end of a typedef.  Wrong OS
> >    Greg> style guide.
> >
> > Just out of curiousity, who wrote the line
> >
> > 	typedef int __bitwise kobject_action_t;
> >
> > in <linux/kobject_uevent.h>?  From the changelog it almost looks like
> > you did it ;)
>
>
> Yeah, at Linus's insistance.  See his email about the whole __bitwise
> stuff for that :(
>
> But I did it for a simple variable type.  Not a structure.
>
> /me justifies it to himself somehow...

And you are right to do so.  Typedefs for base types make a lot of
sense.  Just don't obfuscate structs with them.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/