Re: [PATCH] oom killer (Core)

From: Andrea Arcangeli
Date: Wed Dec 01 2004 - 17:37:02 EST


On Wed, Dec 01, 2004 at 11:06:07PM +0100, Thomas Gleixner wrote:
> On Wed, 2004-12-01 at 22:16 +0100, Andrea Arcangeli wrote:
> > On Wed, Dec 01, 2004 at 10:49:03AM +0100, tglx@xxxxxxxxxxxxx wrote:
> > > It gets invoked multiple times [..]
> >
> > You didn't move the invocation in page_alloc.c which is the major bug I
> > can see (besides the other hacks in oom_kill.c). I'd try fixing the
> > major bug first.
>
> Where do you want to move it ?
>
> I don't buy that moving the invocation to any place will solve the
> problem of multiple invocations.

It has to check the levels of free memory before calling oom_kill.c and
that's the usual check that alloc_pages does.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/