Re: [2.6.9+] PnPBIOS: Missing SMALL_TAG_ENDDEP tag

From: Rene Herman
Date: Mon Dec 06 2004 - 16:13:25 EST


Adam Belay wrote:

I appreciate the additional information. I looked through the binary files
manually and confirmed that they are missing an end-dep tag. It should be
harmless however. I think the error message needs to be debug or it could be removed.

As far as I'm concerned, making it debug is not too useful. I normally have pnp debug enabled but not to debug my BIOS.

Hence attachment. Could you push it on yourself if you agree? Thanks...

Rene.


--- linux-2.6.10-rc3.orig/drivers/pnp/pnpbios/rsparser.c 2004-12-04 03:10:03.000000000 +0100
+++ linux-2.6.10-rc3/drivers/pnp/pnpbios/rsparser.c 2004-12-06 01:59:44.000000000 +0100
@@ -439,11 +439,7 @@
break;

case SMALL_TAG_END:
- if (option_independent != option)
- printk(KERN_WARNING "PnPBIOS: Missing SMALL_TAG_ENDDEP tag\n");
- p = p + 2;
- return (unsigned char *)p;
- break;
+ return p + 2;

default: /* an unkown tag */
len_err: