Re: [mm patch] oprofile: backtrace operation does not initialized

From: Greg Banks
Date: Wed Dec 08 2004 - 19:42:22 EST

On Thu, Dec 09, 2004 at 12:56:23AM +0100, Philippe Elie wrote:
> oprofile_timer_init doesn't reset op->setup/shutdown, I don't like the idea to
> reset them in oprofile_timer_init() it's error prone. John any idea ?

A better long term solution would be not to change the ops structure
but to copy and chain it, as I did in my experimental cswitch patches.
The approach I took allows for a new fake event which can be selected
at runtime with --event instead of with a boot option.

But for now I don't see any drama with leaving in the ->setup() and
->shutdown() methods when rewriting the ops structure. Ditto for
the ->create_files() methods.

Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at