Re: IDE: strange WAIT_READY dependency on APM

From: Pavel Machek
Date: Thu Dec 09 2004 - 05:54:33 EST


Hi!

> IDE contains the following strange code:
>
> <-- snip -->
>
> #if defined(CONFIG_APM) || defined(CONFIG_APM_MODULE)
> #define WAIT_READY (5*HZ) /* 5sec - some laptops are very slow */
> #else
> #define WAIT_READY (HZ/10) /* 100msec - should be instantaneous */
> #endif /* CONFIG_APM || CONFIG_APM_MODULE */
>
> <-- snip -->
>
> On the one hand APM isn't enabled on all laptops.
> On the other hand, this also affects regular PCs with APM support (or
> using a distribution kernel with APM support).
>
> The time for the !APM case was already increased from 30msec in 2.4 .
> Isn't there a timeout that is suitable for all cases?

We should probably always make it the "big" timeout. Or put there
HZ/10, and see who screams :-).

Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/